Add support for Baryanic Leylines (Disciple of Varashta)#1804
Open
awlego wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
Open
Add support for Baryanic Leylines (Disciple of Varashta)#1804awlego wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
awlego wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
Conversation
Parse "Non-Unique Time-Lost Jewels have X% increased radius" into a NonUniqueTimeLostJewelRadius modifier. When the build has the modifier, non-unique Time-Lost Jewels swap to a precomputed +40% radius tier for the in-radius passive computation and for the socket ring drawn on the tree. Regenerated ModCache.lua accordingly.
- Append "(+X% from tree)" to the jewel tooltip Radius line when a build has NonUniqueTimeLostJewelRadius active. - Skip Time-Lost upgrade radius indexes in the AddNodeTooltip probe set unless the build actually has access to them, avoiding unnecessary ProcessStats calls per hover.
Author
|
Updated the PR with the latest so modcache should be up to date as well as did some polish around the tooltip. |
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Adds support for Baryanic Leylines (Disciple of Varashta). The tree entry for "Non-Unique Time-Lost Jewels have 40% increased radius" existed but had no parser, so allocating the notable did nothing.
ModParser.luaparses the stat into aNonUniqueTimeLostJewelRadiusINC mod.Data.luaadds four precomputed +40% radius tiers plus aresolveTimeLostRadiusIndexhelper keyed by percent.CalcSetup.luaandPassiveTreeView.luacall the helper so in-radius calcs, the socket ring, and node tooltips all use the upgraded radius on non-unique Time-Lost jewels.ModCache.luaregenerated; new spec added.Steps taken to verify a working solution:
devbranch plus this change, picked a Sorceress, allocated Disciple of Varashta → Baryanic Leylines.NonUniqueTimeLostJewelRadius INC 40Small Passives in Radius also grant X%roll into an allocated jewel socket; recorded which passives it affected before allocating Baryanic Leylines.TestBaryanicLeylines_spec.luaLink to a build that showcases this PR:
Before screenshot:
(without Baryonic Leylines)
(with Baryonic Leylines)
(and a before shot of a passive outside the ring)
After screenshot:
Showing that the Baryanic Leylines node shows that it is supported and the effects it will have on the build.
Same build/view on this branch, ring now visibly expanded and a previously-unaffected passive showing the jewel's inherited stats in its tooltip.